Handle a blank value for the http_proxy host #18073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugzilla.redhat.com/show_bug.cgi?id=1637092 We have no way (in the UI) to remove a previously configured http_proxy host in Settings.yml/advanced settings, so people were forced to save a '' value. This code was only checking for nil values and should really check for blank values. It doesn't make sense to reimplement the regex used by the URI class to parse host values for validity but handling some obvious blank values make sense here.
|
Thanks @yrudman, I updated the bz with links to the bz for the PRs you referenced. |
|
@jrafanie Can this be |
|
Yes, it can. |
simaishi
pushed a commit
that referenced
this pull request
Oct 15, 2018
Handle a blank value for the http_proxy host (cherry picked from commit a17d07e) https://bugzilla.redhat.com/show_bug.cgi?id=1637092
|
Hammer backport details: |
simaishi
pushed a commit
that referenced
this pull request
Nov 5, 2018
Handle a blank value for the http_proxy host (cherry picked from commit a17d07e) https://bugzilla.redhat.com/show_bug.cgi?id=1639353
|
Hammer backport details: |
nizaminabeel
pushed a commit
to nizaminabeel/manageiq
that referenced
this pull request
Dec 11, 2018
…xy_host Handle a blank value for the http_proxy host (cherry picked from commit a17d07e) https://bugzilla.redhat.com/show_bug.cgi?id=1639353
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1637092
We have no way (in the UI) to remove a previously configured http_proxy host
in Settings.yml/advanced settings, so people were forced to save a ''
value. This code was only checking for nil values and should really
check for blank values. It doesn't make sense to reimplement the regex
used by the URI class to parse host values for validity but handling
some obvious blank values make sense here.